Conversation
There was a problem hiding this comment.
Pull request overview
Updates API authentication enforcement so JSON-format requests (in addition to XML) require an API key unless a user is logged in, aligning controller behavior with the goal of protecting JSON responses.
Changes:
- Replace the XML-only API access filter with a unified
verify_api_accessfilter that handles both XML and JSON. - Enforce API key checks for JSON requests (with an explicit exception for logged-in users).
- Expand controller test coverage to assert JSON authentication behavior for
AccountsController#show.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
test/controllers/accounts_controller_test.rb |
Adds/adjusts tests to require API keys for anonymous JSON show, while allowing logged-in JSON access. |
app/controllers/stacks_controller.rb |
Switches project_stacks to the new unified API access filter. |
app/controllers/sitemap_controller.rb |
Updates the skip hook to match the renamed unified API access filter. |
app/controllers/kudos_controller.rb |
Switches index/sent to the new unified API access filter. |
app/controllers/application_controller.rb |
Replaces XML-only gating with a unified XML/JSON verify_api_access implementation (with JSON session exception). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Priya5
approved these changes
Sep 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.